Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000071Rosetta[All Projects] Bad Codingpublic2012-08-15 13:022012-08-15 13:24
Assigned Tosmlewis 
Platformx86OSLinuxOS VersionUbuntu
Product VersionAll 
Fixed in VersionTrunk 
Summary0000071: InterfaceAnalyzerMover.hh should have full ScoreFunction.hh
DescriptionInterfaceAnalyzerMover.hh currently:

#include <core/scoring/ScoreFunction.fwd.hh>

However, its constructors include:
        core::scoring::ScoreFunctionCOP sf = NULL,

As a consequence of this, anybody wishing to instantiate InterfaceAnalyzerMover is non-obviously required to be able to instantiate ScoreFunctionCOPs. Even if you use the default constructor with no arguments (allowing NULL for the sf OP), gcc requires the ScoreFunction full header. This leads to non-obvious compilation errors if you try to just do

InterfaceAnalyzerMover my_mover;
Additional InformationI will be swapping the .fwd.hh for .hh shortly.
TagsNo tags attached.
Application(s) AffectedInterfaceAnalyzer; its clients
Command Line Usedcompilation error
Developer OptionsConfirmed As Bug
Fixed in SVN Version50383
Attached Files

- Relationships

-  Notes
smlewis (Administrator)
2012-08-15 13:24

Comment in code to leave as full .hh (won't stop autofixers, but will stop casual "hey, that violates convention" fixes)

- Issue History
Date Modified Username Field Change
2012-08-15 13:02 smlewis New Issue
2012-08-15 13:02 smlewis Status new => assigned
2012-08-15 13:02 smlewis Assigned To => smlewis
2012-08-15 13:24 smlewis Fixed in SVN Version => 50383
2012-08-15 13:24 smlewis Note Added: 0000055
2012-08-15 13:24 smlewis Status assigned => resolved
2012-08-15 13:24 smlewis Fixed in Version => Trunk
2012-08-15 13:24 smlewis Resolution open => fixed

Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker