0000071: InterfaceAnalyzerMover.hh should have full ScoreFunction.hh

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000071

Rosetta

[All Projects] Bad Coding

public

2012-08-15 13:02

2012-08-15 13:24

Reporter

smlewis

Assigned To

smlewis

Priority

low

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

x86

Linux

OS Version

Ubuntu

Product Version

All

Fixed in Version

Trunk

Summary

0000071: InterfaceAnalyzerMover.hh should have full ScoreFunction.hh

Description

InterfaceAnalyzerMover.hh currently:

#include <core/scoring/ScoreFunction.fwd.hh>

However, its constructors include:
    InterfaceAnalyzerMover(
                ...
        core::scoring::ScoreFunctionCOP sf = NULL,
        ...
    );

As a consequence of this, anybody wishing to instantiate InterfaceAnalyzerMover is non-obviously required to be able to instantiate ScoreFunctionCOPs. Even if you use the default constructor with no arguments (allowing NULL for the sf OP), gcc requires the ScoreFunction full header. This leads to non-obvious compilation errors if you try to just do

InterfaceAnalyzerMover my_mover;

Additional Information

I will be swapping the .fwd.hh for .hh shortly.

Tags

No tags attached.

Application(s) Affected

InterfaceAnalyzer; its clients

Command Line Used

compilation error

Developer Options

Confirmed As Bug

Fixed in SVN Version

50383

Attached Files

Relationships

Notes
(0000055) smlewis (Administrator) 2012-08-15 13:24	Comment in code to leave as full .hh (won't stop autofixers, but will stop casual "hey, that violates convention" fixes)

Issue History
Date Modified	Username	Field	Change
2012-08-15 13:02	smlewis	New Issue
2012-08-15 13:02	smlewis	Status	new => assigned
2012-08-15 13:02	smlewis	Assigned To	=> smlewis
2012-08-15 13:24	smlewis	Fixed in SVN Version	=> 50383
2012-08-15 13:24	smlewis	Note Added: 0000055
2012-08-15 13:24	smlewis	Status	assigned => resolved
2012-08-15 13:24	smlewis	Fixed in Version	=> Trunk
2012-08-15 13:24	smlewis	Resolution	open => fixed