Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000336Rosetta[All Projects] Bad Codingpublic2014-06-06 08:542014-06-24 16:30
Assigned Tormoretti 
PlatformOSOS Version
Product Version 
Fixed in Version 
Summary0000336: core::util::add_cutpoint_variants() and remove_cutpoint_variants() take raw pointers
DescriptionAgainst coding conventions, core::util::add_cutpoint_variants() and remove_cutpoint_variants() take raw pointers to a Pose. They should be re-written to either take an owning pointer, or (preferably) a reference to a Pose
TagsNo tags attached.
Application(s) Affectedna
Command Line Usedna
Developer OptionsConfirmed As Bug
Fixed in SVN Version56982
Attached Files

- Relationships
related to 0000341new Too many add_cutpoint/chainbreak_variants functions 

-  Notes
jrporter (Attentive Developer)
2014-06-06 09:24

Removing the pointer should be easy to do, but while we're at it, we might also want to ask ourselves how this function differs from:


In fairness, the last one is depricated and the penultimate is mine, but I'd love to get rid of them with some lower-level API call, if we can. I think we need to consider that not all fold tree cuts must necessarily be replaced with chainbreaks.
rmoretti (Attentive Developer)
2014-06-24 16:29

The core of the issue (the raw pointers) has been addressed. The additional issue that Justin raised has been added as a new bug (0000341).

- Issue History
Date Modified Username Field Change
2014-06-06 08:54 rmoretti New Issue
2014-06-06 09:24 jrporter Note Added: 0000346
2014-06-21 11:03 rmoretti Assigned To => rmoretti
2014-06-21 11:03 rmoretti Status new => assigned
2014-06-24 16:29 rmoretti Fixed in SVN Version => 56982
2014-06-24 16:29 rmoretti Note Added: 0000348
2014-06-24 16:29 rmoretti Status assigned => resolved
2014-06-24 16:29 rmoretti Resolution open => fixed
2014-06-24 16:30 rmoretti Relationship added related to 0000341

Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker