| Anonymous | Login | 2024-10-11 13:36 CDT |  |
| My View | View Issues |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0000336 | Rosetta | [All Projects] Bad Coding | public | 2014-06-06 08:54 | 2014-06-24 16:30 | ||||
| Reporter | rmoretti | ||||||||
| Assigned To | rmoretti | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Fixed in Version | |||||||||
| Summary | 0000336: core::util::add_cutpoint_variants() and remove_cutpoint_variants() take raw pointers | ||||||||
| Description | Against coding conventions, core::util::add_cutpoint_variants() and remove_cutpoint_variants() take raw pointers to a Pose. They should be re-written to either take an owning pointer, or (preferably) a reference to a Pose | ||||||||
| Tags | No tags attached. | ||||||||
| Application(s) Affected | na | ||||||||
| Command Line Used | na | ||||||||
| Developer Options | Confirmed As Bug | ||||||||
| Fixed in SVN Version | 56982 | ||||||||
| Attached Files | |||||||||
 Relationships |
||||||
|
||||||
 Relationships |
|
Notes |
|
|
(0000346) jrporter (Attentive Developer) 2014-06-06 09:24 |
Removing the pointer should be easy to do, but while we're at it, we might also want to ask ourselves how this function differs from: core::util::pose::correctly_add_cutpoint_variants protocols::forge::methods::add_cutpoint_variants protocols::loops::loops_main::add_cutpoint_variants protocols::abinitio::add_chainbreak_variants protocols::environment::add_chainbreak_variants protocols::topology_broker::add_chainbreak_variants In fairness, the last one is depricated and the penultimate is mine, but I'd love to get rid of them with some lower-level API call, if we can. I think we need to consider that not all fold tree cuts must necessarily be replaced with chainbreaks. |
|
(0000348) rmoretti (Attentive Developer) 2014-06-24 16:29 |
The core of the issue (the raw pointers) has been addressed. The additional issue that Justin raised has been added as a new bug (0000341). |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-06-06 08:54 | rmoretti | New Issue | |
| 2014-06-06 09:24 | jrporter | Note Added: 0000346 | |
| 2014-06-21 11:03 | rmoretti | Assigned To | => rmoretti |
| 2014-06-21 11:03 | rmoretti | Status | new => assigned |
| 2014-06-24 16:29 | rmoretti | Fixed in SVN Version | => 56982 |
| 2014-06-24 16:29 | rmoretti | Note Added: 0000348 | |
| 2014-06-24 16:29 | rmoretti | Status | assigned => resolved |
| 2014-06-24 16:29 | rmoretti | Resolution | open => fixed |
| 2014-06-24 16:30 | rmoretti | Relationship added | related to 0000341 |
|
Issue History |
| Copyright © 2000 - 2012 MantisBT Group |
|