0000248: integration.py handles missing command files poorly

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000248

Rosetta

[All Projects] Crash

public

2013-04-11 14:30

2013-04-11 17:40

Reporter

smlewis

Assigned To

Sergey

Priority

normal

Severity

minor

Reproducibility

always

Status

assigned

Resolution

open

Platform

OS Version

Product Version

Fixed in Version

Summary

0000248: integration.py handles missing command files poorly

Description

Create a test directory within integration/tests with no command file.

integration.py will fail with something like:
Traceback (most recent call last):
  File "integration.py", line 1011, in <module>
    sys.exit(main(sys.argv[1:]))
  File "integration.py", line 264, in main
    cmd_line_sh, workdir = generateIntegrationTestCommandline(test, outdir);
  File "integration.py", line 671, in generateIntegrationTestCommandline
    cmd += file(path.join(workdir, "command")).read().strip()
IOError: [Errno 2] No such file or directory: '/home/sml58/git_rosetta/rosetta_tests/integration/new/ccd_loop_terminal/command'

It is correct in that it knows the command file doesn't exist, but it should probably catch the nonexistence of the file and handle it as a permafail test, instead of crashing integration.py.

Additionally, child processes of integration.py are NOT KILLED when it dies in this fashion - so if you're running at -j8, your other 7 don't die immediately. They should be killed when integration.py dies. Maybe that's a separate bug. I guess integration.py does not need to die here anyway.

Tags

No tags attached.

Application(s) Affected

integration test

Command Line Used

integration.py this_test_has_no_command_file

Developer Options

Feature Request, Confirmed As Bug

Fixed in SVN Version

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2013-04-11 14:30	smlewis	New Issue
2013-04-11 17:40	Sergey	Assigned To	=> Sergey
2013-04-11 17:40	Sergey	Status	new => assigned