0000227: cleanup removal of EXIT_THROWS_EXCEPTION

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000227

Rosetta

[All Projects] Bad Coding

public

2013-03-22 10:03

2013-03-25 13:12

Reporter

smlewis

Assigned To

momeara

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Fixed in Version

Summary

0000227: cleanup removal of EXIT_THROWS_EXCEPTION

Description

Post bug 0000189, we need to remove all the EXIT_THROWS_EXCEPTION mentions in he codebase, since it no longer exists.

I will get the documentation ones, but someone (Matt?) should get the features ones, and someone (?) should get the cmake ones.

Additional Information

rosetta> ack-grep -a EXIT_THROWS_EXCEPTION
rosetta_demos/protocol_capture/2010/AnchoredDesign/raw_documentation/RobustRosetta.dox
33:@li ensure that the preprocessor statement EXIT_THROWS_EXCEPTION is defined. You can do this on command line, or modify user.settings. For example, modify user.settings to include: "appends" : { "defines" : ["EXIT_THROWS_EXCEPTION"], },

rosetta_source/doc/RobustRosetta.dox
33:@li ensure that the preprocessor statement EXIT_THROWS_EXCEPTION is defined. You can do this on command line, or modify user.settings. For example, modify user.settings to include: "appends" : { "defines" : ["EXIT_THROWS_EXCEPTION"], },

rosetta_source/cmake/build_native_client_32/CMakeLists.txt
23:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/cmake/build_backend/CMakeLists.txt
7:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/cmake/build_release_static/CMakeLists.txt
7:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/cmake/build_native_client/CMakeLists.txt
23:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/src/apps/public/interface_design/anchored_design/AnchorFinder.cc
21:// make sure EXIT_THROWS_EXCEPTION is defined in user.settings.

rosetta_source/src/protocols/jd2/JobDistributor.cc
874: std::exit(1); // Using pure exit instead of utility_exit_with_status to avoid recursion when compile with EXIT_THROWS_EXCEPTION

rosetta_source/tools/build/user.settings
31: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_source/tools/build/site.settings.killdevil
31: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_source/tools/build/site.settings.orchestra
51: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_sp2_RTMin/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_relax_sp2/input/README.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_sp2/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_score12prime_RTMin/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_relax/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_sp2_MinPack/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_score12prime_MinPack/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

Tags

No tags attached.

Application(s) Affected

EXIT_THROWS_EXCEPTION

Command Line Used

EXIT_THROWS_EXCEPTION

Developer Options

Fixed in SVN Version

54502

Attached Files

Relationships

related to

0000189

resolved

renfrew

Turn on EXIT_THROWS_EXCEPTION by default

Notes
(0000207) smlewis (Administrator) 2013-03-22 10:12	with SVN 54448, I resolved: rosetta_demos/protocol_capture/2010/AnchoredDesign/raw_documentation/RobustRosetta.dox rosetta_source/doc/RobustRosetta.dox rosetta_source/src/apps/public/interface_design/anchored_design/AnchorFinder.cc rosetta_source/src/protocols/jd2/JobDistributor.cc rosetta_source/tools/build/site.settings.killdevil rosetta_source/tools/build/site.settings.orchestra There is still some question of what the signal handler in JD2 should be doing.

(0000208) renfrew (Developer) 2013-03-22 10:37 edited on: 2013-03-22 10:42	Should rosetta_source/tools/build/user.settings even be tracked by svn/git? EDIT: Nevermind its not. You just have ETE in yours.

(0000209) smlewis (Administrator) 2013-03-22 11:19	You are correct, it's not tracked by git...that's just the return from ack, which doesn't look at .gitignore.

Issue History
Date Modified	Username	Field	Change
2013-03-22 10:03	smlewis	New Issue
2013-03-22 10:03	smlewis	Relationship added	related to 0000189
2013-03-22 10:12	smlewis	Note Added: 0000207
2013-03-22 10:37	renfrew	Note Added: 0000208
2013-03-22 10:42	renfrew	Note Edited: 0000208	View Revisions
2013-03-22 11:19	smlewis	Note Added: 0000209
2013-03-25 13:12	momeara	Fixed in SVN Version	=> 54502
2013-03-25 13:12	momeara	Status	new => resolved
2013-03-25 13:12	momeara	Resolution	open => fixed
2013-03-25 13:12	momeara	Assigned To	=> momeara