0000220: KofNConstraint::calculate_total_cst_score has been returning the wrong total score

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000220

Rosetta

[All Projects] Incorrect Results

public

2013-03-18 01:40

2013-03-18 02:39

Reporter

Labonte

Assigned To

Labonte

Priority

high

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

All platforms

Any

OS Version

Any

Product Version

Trunk

Fixed in Version

Trunk

Summary

0000220: KofNConstraint::calculate_total_cst_score has been returning the wrong total score

Description

While cleaning out warnings, I found the following bug in rosetta_source/src/core/scoring/constraints/KofNConstraint.cc, l. 173:

KofNConstraint::calculate_total_cst_score( EnergyMap const & weights, EnergyMap & emap ) const
{
    core::Real total_score =
            emap[constant_constraint] * weights[constant_constraint] +
            emap[coordinate_constraint] * weights[coordinate_constraint] +
            emap[atom_pair_constraint] * weights[atom_pair_constraint] +
            emap[angle_constraint] * weights[angle_constraint] +
            emap[dihedral_constraint] * weights[dihedral_constraint] +
            emap[backbone_stub_constraint] * weights[backbone_stub_constraint];
            emap[backbone_stub_linear_constraint] * weights[backbone_stub_linear_constraint];

    return total_score;
}

Note that the penultimate emap line has a semicolon where it should have a + sign.

Additional Information

I'll fix this along with my next warnings check in.

Tags

No tags attached.

Application(s) Affected

unknown

Command Line Used

unknown

Developer Options

Fixed in SVN Version

54328

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2013-03-18 01:40	Labonte	New Issue
2013-03-18 02:39	Labonte	Fixed in SVN Version	=> 54328
2013-03-18 02:39	Labonte	Status	new => resolved
2013-03-18 02:39	Labonte	Fixed in Version	=> Trunk
2013-03-18 02:39	Labonte	Resolution	open => fixed
2013-03-18 02:39	Labonte	Assigned To	=> Labonte