0000158: value -1 assigned to Size variable

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000158

Rosetta

[All Projects] Bad Coding

public

2012-12-08 12:06

2013-04-02 18:19

Reporter

Labonte

Assigned To

honda

Priority

high

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

All platforms

Any

OS Version

Any

Product Version

Trunk

Fixed in Version

Trunk

Summary

0000158: value -1 assigned to Size variable

Description

While cleaning Rosetta of warnings, I came to
/rosetta_source/src/protocols/forge/remodel/RemodelWorkingSet.cc, line 427,
where we find the following code:
core::Size head = -1, tail = -1, headNew = -1, tailNew = -1; //safety, init to negative values

This line itself does not throw a warning; however, it triggers several others further down, and I'm pretty sure it's not kosher to assign a negative value to an unsigned integer.

Could someone who wrote or knows more about this code take care of this for me? Thanks!

Tags

No tags attached.

Application(s) Affected

unknown

Command Line Used

N/A

Developer Options

Fixed in SVN Version

54161

Attached Files

Relationships

related to

0000219

resolved

dimaio

negative values assigned to Size in CartesianBondedEnergy.cc

Notes
(0000184) Labonte (Developer) 2013-03-17 19:32	Anyone?

(0000185) smlewis (Administrator) 2013-03-18 13:25	svn blame suggests you need to talk to Pos-su Huang and Ron Jacak.

Issue History
Date Modified	Username	Field	Change
2012-12-08 12:06	Labonte	New Issue
2012-12-08 12:07	Labonte	Description Updated	View Revisions
2013-02-26 12:12	smlewis	Project	PyRosetta => Rosetta
2013-03-17 19:32	Labonte	Note Added: 0000184
2013-03-17 19:33	Labonte	Relationship added	related to 0000219
2013-03-18 13:25	smlewis	Note Added: 0000185
2013-04-02 18:19	Labonte	Fixed in SVN Version	=> 54161
2013-04-02 18:19	Labonte	Status	new => resolved
2013-04-02 18:19	Labonte	Fixed in Version	=> Trunk
2013-04-02 18:19	Labonte	Resolution	open => fixed
2013-04-02 18:19	Labonte	Assigned To	=> honda