MantisBT - Rosetta
View Issue Details
0000336Rosetta[All Projects] Bad Codingpublic2014-06-06 08:542014-06-24 16:30
rmoretti 
rmoretti 
normalminoralways
resolvedfixed 
 
 
na
na
Confirmed As Bug
56982
0000336: core::util::add_cutpoint_variants() and remove_cutpoint_variants() take raw pointers
Against coding conventions, core::util::add_cutpoint_variants() and remove_cutpoint_variants() take raw pointers to a Pose. They should be re-written to either take an owning pointer, or (preferably) a reference to a Pose
No tags attached.
related to 0000341new  Too many add_cutpoint/chainbreak_variants functions 
Issue History
2014-06-06 08:54rmorettiNew Issue
2014-06-06 09:24jrporterNote Added: 0000346
2014-06-21 11:03rmorettiAssigned To => rmoretti
2014-06-21 11:03rmorettiStatusnew => assigned
2014-06-24 16:29rmorettiFixed in SVN Version => 56982
2014-06-24 16:29rmorettiNote Added: 0000348
2014-06-24 16:29rmorettiStatusassigned => resolved
2014-06-24 16:29rmorettiResolutionopen => fixed
2014-06-24 16:30rmorettiRelationship addedrelated to 0000341

Notes
(0000346)
jrporter   
2014-06-06 09:24   
Removing the pointer should be easy to do, but while we're at it, we might also want to ask ourselves how this function differs from:

core::util::pose::correctly_add_cutpoint_variants
protocols::forge::methods::add_cutpoint_variants
protocols::loops::loops_main::add_cutpoint_variants
protocols::abinitio::add_chainbreak_variants
protocols::environment::add_chainbreak_variants
protocols::topology_broker::add_chainbreak_variants


In fairness, the last one is depricated and the penultimate is mine, but I'd love to get rid of them with some lower-level API call, if we can. I think we need to consider that not all fold tree cuts must necessarily be replaced with chainbreaks.
(0000348)
rmoretti   
2014-06-24 16:29   
The core of the issue (the raw pointers) has been addressed. The additional issue that Justin raised has been added as a new bug (0000341).