MantisBT - Rosetta
View Issue Details
0000227Rosetta[All Projects] Bad Codingpublic2013-03-22 10:032013-03-25 13:12
smlewis 
momeara 
normalminoralways
resolvedfixed 
 
 
EXIT_THROWS_EXCEPTION
EXIT_THROWS_EXCEPTION
54502
0000227: cleanup removal of EXIT_THROWS_EXCEPTION
Post bug 0000189, we need to remove all the EXIT_THROWS_EXCEPTION mentions in he codebase, since it no longer exists.

I will get the documentation ones, but someone (Matt?) should get the features ones, and someone (?) should get the cmake ones.
rosetta> ack-grep -a EXIT_THROWS_EXCEPTION
rosetta_demos/protocol_capture/2010/AnchoredDesign/raw_documentation/RobustRosetta.dox
33:@li ensure that the preprocessor statement EXIT_THROWS_EXCEPTION is defined. You can do this on command line, or modify user.settings. For example, modify user.settings to include: "appends" : { "defines" : ["EXIT_THROWS_EXCEPTION"], },

rosetta_source/doc/RobustRosetta.dox
33:@li ensure that the preprocessor statement EXIT_THROWS_EXCEPTION is defined. You can do this on command line, or modify user.settings. For example, modify user.settings to include: "appends" : { "defines" : ["EXIT_THROWS_EXCEPTION"], },

rosetta_source/cmake/build_native_client_32/CMakeLists.txt
23:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/cmake/build_backend/CMakeLists.txt
7:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/cmake/build_release_static/CMakeLists.txt
7:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/cmake/build_native_client/CMakeLists.txt
23:ADD_DEFINITIONS(-DEXIT_THROWS_EXCEPTION)

rosetta_source/src/apps/public/interface_design/anchored_design/AnchorFinder.cc
21:// make sure EXIT_THROWS_EXCEPTION is defined in user.settings.

rosetta_source/src/protocols/jd2/JobDistributor.cc
874: std::exit(1); // Using pure exit instead of utility_exit_with_status to avoid recursion when compile with EXIT_THROWS_EXCEPTION

rosetta_source/tools/build/user.settings
31: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_source/tools/build/site.settings.killdevil
31: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_source/tools/build/site.settings.orchestra
51: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_sp2_RTMin/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_relax_sp2/input/README.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_sp2/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_score12prime_RTMin/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_relax/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_sp2_MinPack/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],

rosetta_tests/features/sample_sources/top8000_rotamer_recovery_score12prime_MinPack/input/REAME.txt
10: "defines" : ["EXIT_THROWS_EXCEPTION"],
No tags attached.
related to 0000189resolved renfrew Turn on EXIT_THROWS_EXCEPTION by default 
Issue History
2013-03-22 10:03smlewisNew Issue
2013-03-22 10:03smlewisRelationship addedrelated to 0000189
2013-03-22 10:12smlewisNote Added: 0000207
2013-03-22 10:37renfrewNote Added: 0000208
2013-03-22 10:42renfrewNote Edited: 0000208bug_revision_view_page.php?bugnote_id=208#r65
2013-03-22 11:19smlewisNote Added: 0000209
2013-03-25 13:12momearaFixed in SVN Version => 54502
2013-03-25 13:12momearaStatusnew => resolved
2013-03-25 13:12momearaResolutionopen => fixed
2013-03-25 13:12momearaAssigned To => momeara

Notes
(0000207)
smlewis   
2013-03-22 10:12   
with SVN 54448, I resolved:

    rosetta_demos/protocol_capture/2010/AnchoredDesign/raw_documentation/RobustRosetta.dox
    rosetta_source/doc/RobustRosetta.dox
    rosetta_source/src/apps/public/interface_design/anchored_design/AnchorFinder.cc
    rosetta_source/src/protocols/jd2/JobDistributor.cc
    rosetta_source/tools/build/site.settings.killdevil
    rosetta_source/tools/build/site.settings.orchestra

There is still some question of what the signal handler in JD2 should be doing.
(0000208)
renfrew   
2013-03-22 10:37   
(edited on: 2013-03-22 10:42)
Should rosetta_source/tools/build/user.settings even be tracked by svn/git?

EDIT: Nevermind its not. You just have ETE in yours.

(0000209)
smlewis   
2013-03-22 11:19   
You are correct, it's not tracked by git...that's just the return from ack, which doesn't look at .gitignore.