MantisBT - Rosetta
View Issue Details
0000158Rosetta[All Projects] Bad Codingpublic2012-12-08 12:062013-04-02 18:19
Labonte 
honda 
highminoralways
resolvedfixed 
All platformsAnyAny
Trunk 
Trunk 
unknown
N/A
54161
0000158: value -1 assigned to Size variable
While cleaning Rosetta of warnings, I came to
/rosetta_source/src/protocols/forge/remodel/RemodelWorkingSet.cc, line 427,
where we find the following code:
core::Size head = -1, tail = -1, headNew = -1, tailNew = -1; //safety, init to negative values

This line itself does not throw a warning; however, it triggers several others further down, and I'm pretty sure it's not kosher to assign a negative value to an unsigned integer.

Could someone who wrote or knows more about this code take care of this for me? Thanks!
No tags attached.
related to 0000219resolved dimaio negative values assigned to Size in CartesianBondedEnergy.cc 
Issue History
2012-12-08 12:06LabonteNew Issue
2012-12-08 12:07LabonteDescription Updatedbug_revision_view_page.php?rev_id=45#r45
2013-02-26 12:12smlewisProjectPyRosetta => Rosetta
2013-03-17 19:32LabonteNote Added: 0000184
2013-03-17 19:33LabonteRelationship addedrelated to 0000219
2013-03-18 13:25smlewisNote Added: 0000185
2013-04-02 18:19LabonteFixed in SVN Version => 54161
2013-04-02 18:19LabonteStatusnew => resolved
2013-04-02 18:19LabonteFixed in Version => Trunk
2013-04-02 18:19LabonteResolutionopen => fixed
2013-04-02 18:19LabonteAssigned To => honda

Notes
(0000184)
Labonte   
2013-03-17 19:32   
Anyone?
(0000185)
smlewis   
2013-03-18 13:25   
svn blame suggests you need to talk to Pos-su Huang and Ron Jacak.