MantisBT - Rosetta
View Issue Details
0000142Rosetta[All Projects] Bad Codingpublic2012-10-23 11:122012-10-23 13:18
smlewis 
smlewis 
lowminoralways
resolvedfixed 
 
 
--
--
51768
0000142: Residue and ResidueType dangerously share method signatures
In Gordon's creation of chemical::Atom, I noticed that ResidueType and Residue both have functions named xyz(). This seems dangerous for new coders - code accidentally using the ResidueType version would compile fine, but they were likely to want the Residue version. Any objections to me renaming ResidueType's functions to indicate their ideality and prevent accidental use (probably as ideal_xyz)?
No tags attached.
Issue History
2012-10-23 11:12smlewisNew Issue
2012-10-23 11:12smlewisStatusnew => assigned
2012-10-23 11:12smlewisAssigned To => smlewis
2012-10-23 12:05smlewisSummaryResidue and ResidueType dangerous share method signatures => Residue and ResidueType dangerously share method signatures
2012-10-23 13:18smlewisFixed in SVN Version => 51768
2012-10-23 13:18smlewisStatusassigned => resolved
2012-10-23 13:18smlewisResolutionopen => fixed

There are no notes attached to this issue.